Creating a FFmpeg library along with a test … #1849
Conversation
… not FFmpeg is installed on the machine running the test. Change: 119061788
|
Can one of the admins verify this patch? |
|
Jenkins, test this please. |
|
Jenkins, test this please? |
|
|
||
| #include <stdlib.h> | ||
|
|
||
| #include "tensorflow/core/lib/core/command_line_flags.h" |
There was a problem hiding this comment.
Hi @fredbertsch: we are trying hard to get rid of command_line_flags from libraries --- can you remove the need for this?
There was a problem hiding this comment.
Are we trying to remove them from tests as well? This isn't in a library. For context, this flag is passing in some context about the test environment to the test. We could also do that with an environment variable, but that's even worse.
There was a problem hiding this comment.
Trying to get rid of it from everywhere except in example binaries.
|
@tensorflow-jenkins test this please. |
|
@tensorflow-jenkins test this please |
|
@tensorflow-jenkins test this please |
|
@tensorflow-jenkins test this please |
|
Jenkins, test this please. |
|
Jenkins, test this please, again. |
|
Jenkins, test this please |
|
@tensorflow-jenkins test this please |
…ers-doc Add TF2.10 to rocm_docs release page
… that will work whether or not FFmpeg is installed on the machine running the test. This also creates a set of integration tests that will be run during the nightly build.
Change: 119061788