Fix bugs in the indexing operator with latest NumPy #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`int()`. Previously, the `_SliceHelper()` would test for `isinstance(..., int)`, which is too restrictive.
|
Can one of the admins verify this patch? |
|
@tensorflow-jenkins, test this please. |
fsx950223
pushed a commit
to fsx950223/tensorflow
that referenced
this pull request
Nov 28, 2023
…upstream-sync-221024 Develop upstream sync 221024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.random.random_integers()is deprecated and recently started returning non-intvalues. This PR fixes this so that thetf.Tensorindexing operator can handle non-int(but convertable-to-int) values, and removes the deprecated method from the test.