Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just fix little issue that is model_file_type variable but not using it in iOS DEMO. #19149

Merged
merged 2 commits into from
Aug 9, 2018

Conversation

tucan9389
Copy link
Member

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@tucan9389
Copy link
Member Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 8, 2018
@tucan9389 tucan9389 changed the title Just fix little issue that is model_file_type variable but not using it. Just fix little issue that is model_file_type variable but not using it in iOS DEMO. May 8, 2018
@rmlarsen rmlarsen requested a review from sb2nov May 8, 2018 17:31
@rmlarsen rmlarsen self-assigned this May 8, 2018
@sb2nov sb2nov requested review from aselle and removed request for sb2nov May 8, 2018 17:47
@rmlarsen rmlarsen added the awaiting review Pull request awaiting review label May 9, 2018
@tensorflowbutler
Copy link
Member

Nagging Reviewer @aselle: It has been 16 days with no activity and the awaiting review label was assigned. Can you please take a look?

Just update clang-tidy to `clang-tidy`.
@tucan9389
Copy link
Member Author

Why is this awaited a long time?.. Am I missing something for my process?

@tensorflowbutler
Copy link
Member

Nagging Reviewer @aselle: It has been 15 days with no activity and the awaiting review label was assigned. Can you please take a look?

@tensorflowbutler
Copy link
Member

Nagging Reviewer @aselle: It has been 30 days with no activity and the awaiting review label was assigned. Can you please take a look?

@rmlarsen rmlarsen added awaiting testing (then merge) kokoro:force-run Tests on submitted change and removed awaiting review Pull request awaiting review labels Jul 17, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 17, 2018
@rmlarsen rmlarsen added the ready to pull PR ready for merge process label Jul 17, 2018
@tensorflowbutler
Copy link
Member

Nagging Assignee @rmlarsen: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@tensorflow-copybara tensorflow-copybara merged commit d46c73a into tensorflow:master Aug 9, 2018
tensorflow-copybara pushed a commit that referenced this pull request Aug 9, 2018
PiperOrigin-RevId: 207985466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants