fix character access in autograph #21580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdanatg could you take a look? |
|
Nagging Reviewer @mdanatg: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 16 days with no activity and the |
|
This is great! Sorry for the delay, I just got back from vacation. |
mdanatg
previously approved these changes
Aug 31, 2018
| @@ -46,6 +46,19 @@ def test_get_item_tensor_list(self): | |||
| with self.test_session() as sess: | |||
| self.assertAllEqual(sess.run(t), [3, 4]) | |||
|
|
|||
| def test_get_item_tensor_string(self): | |||
| initial_str = constant_op.constant("abcd") | |||
There was a problem hiding this comment.
For consistency, please use single quotation marks for single-line strings.
|
@mdanatg you are right, fixed. |
mdanatg
previously approved these changes
Sep 4, 2018
|
I just realized this will raise error for tensor of string. This should only apply for string with rank 0. |
mdanatg
reviewed
Sep 4, 2018
| @@ -58,7 +58,7 @@ def get_item(target, i, opts): | |||
| elif tensor_util.is_tensor(target): | |||
| if target.dtype == dtypes.variant: | |||
| return _tf_tensor_list_get_item(target, i, opts) | |||
| if target.dtype == dtypes.string: | |||
| elif target.dtype == dtypes.string and target.get_shape() == (): # target is string with rank 0 | |||
There was a problem hiding this comment.
More idiomatic: target.shape.ndims == 0
https://www.tensorflow.org/api_docs/python/tf/TensorShape#ndims
mdanatg
approved these changes
Sep 5, 2018
tensorflow-copybara
pushed a commit
that referenced
this pull request
Sep 8, 2018
PiperOrigin-RevId: 212122272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #20703 by extending the tensor index operator.