Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordering for configurable and non-configurable optimizers #22453

Merged
merged 2 commits into from
Sep 22, 2018
Merged

Ordering for configurable and non-configurable optimizers #22453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bce52a
Add possibility to include default optimizers in custom optimizer list
samikama Sep 21, 2018
0598bbc
Minor style fix.
drpngx Sep 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions tensorflow/core/grappler/optimizers/meta_optimizer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,16 @@ Status MetaOptimizer::InitializeCustomGraphOptimizers(
TF_RETURN_IF_ERROR(custom_optimizer->Init(&optimizer_config));
optimizers->push_back(std::move(custom_optimizer));
} else {
// If there are no custom optimizers with given name, try to initalize a
// default optimizer. This way, custom configurable optimizers can be
// mixed with default optimizers in any order.
auto optimizer = MakeNewOptimizer(optimizer_config.name());
if (optimizer) {
VLOG(2) << "Registered default graph optimizer: "
<< optimizer_config.name();
optimizers->push_back(std::move(optimizer));
continue;
}
VLOG(2) << "Can't register an optimizer by name: "
<< optimizer_config.name();
}
Expand Down