Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the logging for OutofRangeError in test #22461

Merged
merged 1 commit into from Sep 24, 2018
Merged

Disable the logging for OutofRangeError in test #22461

merged 1 commit into from Sep 24, 2018

Conversation

feihugis
Copy link
Member

tensorflow.python.framework.test_util.ErrorLoggingSession logs the errors from the tests. However, OutOfRangeError is used in many tf.data Ops as the signal completion, which makes the ouput of tf.data tests hard to read. This PR disables the loging for OutOfRnageError to make the test log easy to read.

@feihugis
Copy link
Member Author

@mrry Could you help review this PR when you have time?

@feihugis feihugis force-pushed the Issue-12414_Error_Logging_Session branch from dbbc9d0 to 040efaa Compare September 22, 2018 07:26
@feihugis feihugis force-pushed the Issue-12414_Error_Logging_Session branch from 040efaa to 6ce84a8 Compare September 22, 2018 08:16
mrry
mrry approved these changes Sep 22, 2018
View reviewed changes
Copy link
Contributor

@mrry mrry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Sep 23, 2018
@mrry mrry added the kokoro:force-run Tests on submitted change label Sep 23, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 23, 2018
@qlzh727 qlzh727 added ready to pull PR ready for merge process and removed awaiting testing (then merge) labels Sep 24, 2018
@tensorflow-copybara tensorflow-copybara merged commit 6ce84a8 into tensorflow:master Sep 24, 2018
tensorflow-copybara pushed a commit that referenced this pull request Sep 24, 2018
@tensorflower-gardener
Merge pull request #22461 from feihugis:Issue-12414_Error_Logging_Ses…
7f71957 
…sion

PiperOrigin-RevId: 214271324
@feihugis feihugis deleted the Issue-12414_Error_Logging_Session branch December 5, 2018 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrry mrry mrry approved these changes

Assignees

@qlzh727 qlzh727

Labels
cla: yes ready to pull PR ready for merge process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@feihugis @mrry @qlzh727 @googlebot @kokoro-team @tensorflow-copybara