Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XLA] AlgebraicSimplifier pass - handle And and Or #23105

Merged
merged 4 commits into from Nov 7, 2018
Merged

[XLA] AlgebraicSimplifier pass - handle And and Or #23105

merged 4 commits into from Nov 7, 2018

Conversation

georgepaw
Copy link
Contributor

Add handling of logical And and Or, where:

  • (a && True) => a
  • (True && a) => a
  • (a && False) => False
  • (False && a) => False
  • (a || True) => True
  • (True || a) => True
  • (a || False) => a
  • (False || a) => a

Added tests for these as well.

@ymodak ymodak self-assigned this Oct 19, 2018
@ymodak ymodak requested a review from hawkinsp October 19, 2018 17:36
@ymodak ymodak added the awaiting review Pull request awaiting review label Oct 19, 2018
@ymodak ymodak requested review from devidipak and congliuthu and removed request for devidipak and hawkinsp November 2, 2018 20:27
congliuthu
congliuthu previously approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@congliuthu congliuthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good % minor nits.

tensorflow/compiler/xla/service/algebraic_simplifier.cc Outdated Show resolved Hide resolved
@ymodak ymodak added stat:awaiting response Status - Awaiting response from author and removed awaiting review Pull request awaiting review labels Nov 2, 2018
@georgepaw
Copy link
Contributor Author

Thank you for the review, all done now

congliuthu
congliuthu approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@congliuthu congliuthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ymodak ymodak added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed stat:awaiting response Status - Awaiting response from author labels Nov 6, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 6, 2018
@tensorflow-copybara tensorflow-copybara merged commit 6ae8cb7 into tensorflow:master Nov 7, 2018
tensorflow-copybara pushed a commit that referenced this pull request Nov 7, 2018
@tensorflower-gardener
Merge pull request #23105 from georgepaw:algebraic_simplifier_handle_…
c846f5f 
…logical_or_and

PiperOrigin-RevId: 220378489
@georgepaw georgepaw deleted the algebraic_simplifier_handle_logical_or_and branch April 25, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congliuthu congliuthu congliuthu approved these changes

Assignees

@ymodak ymodak

Labels
cla: yes ready to pull PR ready for merge process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@georgepaw @congliuthu @googlebot @kokoro-team @tensorflow-copybara @ymodak