Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concat optimization infinite loop #23408

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Fix concat optimization infinite loop #23408

merged 1 commit into from
Apr 30, 2019

Conversation

drasmuss
Copy link
Contributor

This is a fix for the issue identified in #23383

@drasmuss drasmuss mentioned this pull request Oct 31, 2018
Merged
@Harshini-Gadige Harshini-Gadige self-assigned this Oct 31, 2018
@Harshini-Gadige Harshini-Gadige added the awaiting review Pull request awaiting review label Oct 31, 2018
@Harshini-Gadige Harshini-Gadige requested review from skye and removed request for rmlarsen November 19, 2018 22:09
@Harshini-Gadige
Copy link

@skye - PTAL

@skye
Copy link
Member

skye commented Nov 19, 2018

@ezhulenev are you the right person to review this?

@ezhulenev
Copy link
Member

Yes, I'll take a look later today or tomorrow

@Harshini-Gadige Harshini-Gadige requested review from ezhulenev and removed request for skye November 19, 2018 22:34
@Harshini-Gadige
Copy link

Yes, I'll take a look later today or tomorrow

Thank you !

ezhulenev
ezhulenev previously approved these changes Nov 19, 2018
View reviewed changes
@Harshini-Gadige Harshini-Gadige added kokoro:force-run Tests on submitted change and removed awaiting review Pull request awaiting review labels Nov 19, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 19, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 27, 2018
@Harshini-Gadige Harshini-Gadige added the kokoro:force-run Tests on submitted change label Dec 4, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 4, 2018
@Harshini-Gadige Harshini-Gadige added the kokoro:force-run Tests on submitted change label Dec 13, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 13, 2018
@Harshini-Gadige
Copy link

@drasmuss Please address the failures. Thanks !

@drasmuss
Copy link
Contributor Author

drasmuss commented Dec 14, 2018 •
edited

I fixed the one formatting error that I could see. The other failures don't give any indication as to the cause (I can't see the build log), but I rebased this branch onto the latest master as well, in case that helps.

@rthadur rthadur added the size:S CL Change Size: Small label Jan 2, 2019
@Harshini-Gadige Harshini-Gadige added the awaiting review Pull request awaiting review label Jan 14, 2019
@Harshini-Gadige
Copy link

@ezhulenev Request you to take a look and approve this PR. Thanks !

@tensorflowbutler
Copy link
Member

Nagging Reviewer @ezhulenev, @rmlarsen: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 74 days with no activity and the awaiting review label has been applied.

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 23, 2019
@gbaned gbaned assigned gbaned and unassigned Harshini-Gadige Apr 23, 2019
@gbaned
Copy link
Contributor

gbaned commented Apr 29, 2019

@ezhulenev Could you please review and approve this PR? Thanks !

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 29, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 29, 2019
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Apr 29, 2019
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Apr 30, 2019
@tensorflow-copybara tensorflow-copybara merged commit ca4e75a into tensorflow:master Apr 30, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 30, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 30, 2019
@tensorflower-gardener
Merge pull request #23408 from drasmuss:fix-hang
24a3042 
PiperOrigin-RevId: 245943287
@drasmuss drasmuss mentioned this pull request Sep 12, 2019
Closed
@drasmuss drasmuss deleted the fix-hang branch September 12, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezhulenev ezhulenev ezhulenev approved these changes

@rmlarsen rmlarsen Awaiting requested review from rmlarsen

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@drasmuss @Harshini-Gadige @skye @ezhulenev @tensorflowbutler @gbaned @googlebot @kokoro-team @tensorflow-copybara @rthadur