Removed no longer supported call in_eager_execution()
#23560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes to model_analyser.analyse(...): - Swapped context.in_eager_execution() to the currently supported context.executing_eagerly(). - Added negation to eager check. In all likelihood, the negation was always supposed to be there since getting default graph in eager mode does not make sense. The current `if` condition is likely a bug. The proposed fix is consistent with other functions in this module, e.g., `profile(...)`, line 339.
caisq
approved these changes
Nov 6, 2018
ymodak
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Nov 7, 2018
PiperOrigin-RevId: 220378263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to
model_analyser.analyse(...):context.in_eager_execution()to the currently supportedcontext.executing_eagerly().ifcondition is likely a bug. The proposed fix is consistent with other functions in this module, e.g.,profile(...), line 339.