New files for Tensorflow Lite Micro Speech Example targetting the Eta… #24222

hshankar61 · 2018-12-07T19:06:16Z

… Compute ECM3531 evaluation board

googlebot · 2018-12-07T19:06:22Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

hshankar61 · 2018-12-07T19:25:10Z

I signed it

…

On Fri, Dec 7, 2018 at 11:10 AM googlebot ***@***.***> wrote: Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 *Please visit https://cla.developers.google.com/ <https://cla.developers.google.com/> to sign.* Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it. ------------------------------ What to do if you already signed the CLA Individual signers - It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data <https://cla.developers.google.com/clas> and verify that your email is set on your git commits <https://help.github.com/articles/setting-your-email-in-git/>. Corporate signers - Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version <https://opensource.google.com/docs/cla/#troubleshoot>). - The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data <https://cla.developers.google.com/clas> and verify that your email is set on your git commits <https://help.github.com/articles/setting-your-email-in-git/>. - The email used to register you as an authorized contributor must also be attached to your GitHub account <https://github.com/settings/emails>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24222 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aq2lOJJ63pWG0mCPovD4SimhUV45x5-kks5u2r05gaJpZM4ZI_Co> .

hshankar61 · 2018-12-09T05:36:51Z

CLA has been signed again

petewarden

Thanks Hari! I've added some initial comments, could you also run clang-format on the .c files to standardize them with the rest of the code base (selecting the Google style)? This is looking good, I hope we can get it in soon.

petewarden · 2018-12-10T02:47:47Z

tensorflow/lite/experimental/micro/tools/make/targets/ecm3531/_main.c

@@ -0,0 +1,97 @@
+/*******************************************************************************
+ * Copyright (C) 2018 Eta Compute, Inc


Can we update this to be:

Suggested change

* Copyright (C) 2018 Eta Compute, Inc

* Copyright 2018 The TensorFlow Authors. All Rights Reserved.

petewarden · 2018-12-10T02:48:08Z

tensorflow/lite/experimental/micro/tools/make/targets/ecm3531/ecm3531.lds

@@ -0,0 +1,88 @@
+/*******************************************************************************
+ *
+ * Copyright (C) 2018 Eta Compute, Inc


Can you update this to be:

Suggested change

* Copyright (C) 2018 Eta Compute, Inc

* Copyright 2018 The TensorFlow Authors. All Rights Reserved.

petewarden · 2018-12-10T02:49:41Z

tensorflow/lite/experimental/micro/tools/make/targets/ecm3531/load_program

@@ -0,0 +1,35 @@
+#!/usr/bin/python3


Can you add a copyright notice here?

Suggested change

#!/usr/bin/python3

#!/usr/bin/python3

# Copyright 2015 The TensorFlow Authors. All Rights Reserved.

#

# Licensed under the Apache License, Version 2.0 (the "License");

# you may not use this file except in compliance with the License.

# You may obtain a copy of the License at

#

# http://www.apache.org/licenses/LICENSE-2.0

#

# Unless required by applicable law or agreed to in writing, software

# distributed under the License is distributed on an "AS IS" BASIS,

# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

# See the License for the specific language governing permissions and

# limitations under the License.

# ==============================================================================

petewarden · 2018-12-10T02:50:19Z

tensorflow/lite/experimental/micro/tools/make/targets/ecm3531/load_program

@@ -0,0 +1,35 @@
+#!/usr/bin/python3
+


Can you add a quick comment about usage, even if it's just pointing back to the main doc file?

petewarden · 2018-12-10T02:50:57Z

tensorflow/lite/experimental/micro/tools/make/targets/ecm3531/startup.c

@@ -0,0 +1,592 @@
+/*******************************************************************************
+ *
+ * Copyright (C) 2018 Eta Compute, Inc


Can you update this to be:

Suggested change

* Copyright (C) 2018 Eta Compute, Inc

* Copyright 2018 The TensorFlow Authors. All Rights Reserved.

petewarden · 2018-12-10T02:51:22Z

tensorflow/lite/experimental/micro/tools/make/targets/ecm3531/startup.c

+ * limitations under the License.
+ *
+ ******************************************************************************/
+


Can you add some brief comments about what this file is for.

petewarden · 2018-12-10T02:52:52Z

tensorflow/lite/experimental/micro/tools/make/targets/ecm3531/startup.c

+#include "memio.h"
+
+
+//#pragma GCC optimize ("align-functions=16")


Can you remove this dead code?

petewarden · 2018-12-10T02:54:02Z

tensorflow/lite/experimental/micro/tools/make/targets/ecm3531/startup.c

+//
+//*****************************************************************************
+
+#define NAKED	


This is only used in one place that I see, can we just remove it entirely for clarity?

hshankar61 · 2018-12-13T23:46:20Z

I signed it

googlebot · 2018-12-13T23:46:24Z

CLAs look good, thanks!

petewarden · 2018-12-14T03:54:43Z

Is there something else we need to do to trigger the remaining checks that haven't completed? /cc @gunan

petewarden · 2018-12-17T01:26:39Z

The failure in the MacOS Python2 and CC test appears to be unrelated to any code here:

==================== Test output for //tensorflow/core:platform_port_test:
Running main() from test_main.cc
[==========] Running 5 tests from 3 test cases.
[----------] Global test environment set-up.
[----------] 2 tests from Port
[ RUN      ] Port.AlignedMalloc
[       OK ] Port.AlignedMalloc (0 ms)
[ RUN      ] Port.GetCurrentCPU
tensorflow/core/platform/port_test.cc:38: Failure
Expected: (cpu) >= (0), actual: -1 vs 0
[  FAILED  ] Port.GetCurrentCPU (0 ms)

hshankar61 · 2018-12-17T01:35:31Z

So only the copybara check is required. Is there a way to kick that off? Alos, what is the protocol here, should I reply to your emails on Gmail or on Github?

…

On Sun, Dec 16, 2018 at 5:29 PM Pete Warden ***@***.***> wrote: The failure in the MacOS Python2 and CC test appears to be unrelated to any code here: ==================== Test output for //tensorflow/core:platform_port_test: Running main() from test_main.cc [==========] Running 5 tests from 3 test cases. [----------] Global test environment set-up. [----------] 2 tests from Port [ RUN ] Port.AlignedMalloc [ OK ] Port.AlignedMalloc (0 ms) [ RUN ] Port.GetCurrentCPU tensorflow/core/platform/port_test.cc:38: Failure Expected: (cpu) >= (0), actual: -1 vs 0 [ FAILED ] Port.GetCurrentCPU (0 ms) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24222 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aq2lOPBF2k45td88eNLz0I2yVqzYTRbuks5u5vN-gaJpZM4ZI_Co> .

petewarden · 2018-12-17T19:44:04Z

I believe somebody internal should take care of the copybara check once the tests pass, and I've just seen that Gunhan was able to kick off tests by adding the kokoro:force-run flag, so I've tried doing the same to see if we can rerun the tests. Thanks for your patience, hopefully we'll have this through soon!

hshankar61 · 2018-12-17T21:25:34Z

Thanks Pete. Looks like the checks passed!

Causes a missing-copyright error on internal verification

petewarden · 2018-12-17T22:15:24Z

The stub .sh file caused an error internally because it didn't have a copyright notice, so I've removed that and will rerun the tests.

hshankar61 · 2018-12-17T22:56:30Z

Should I check in the test_ecm3531_binary.sh file with the copyright added?

petewarden · 2018-12-17T23:51:41Z

No, I removed it already so I think we're good.

hshankar61 · 2018-12-18T02:06:39Z

There are 3 checks now that are failing but earlier today it showed that all the tests passed. What gives?

hshankar61 · 2018-12-18T16:38:28Z

One point about removing the test_ecm3531_binary.sh file is that the makefile complains about not finding the file and will report that the make failed. It will generate the .elf file though. So this script was added just to satisfy the makefile and not confuse the user who may else thin that there was a compilation error. So it will be good to have this file checked in. But I dont know if the checks that the tensorflow build is now complaining about is related to this or not. make: tensorflow/lite/experimental/micro/testing/test_ecm3531_binary.sh: Command not found /home/hari/tensorflow_fork/tensorflow/tensorflow/lite/experimental/micro/tools/make/Makefile:171: recipe for target 'test_micro_speech' failed make: *** [test_micro_speech] Error 127

…

On Mon, Dec 17, 2018 at 2:19 PM Pete Warden ***@***.***> wrote: The stub .sh file caused an error internally because it didn't have a copyright notice, so I've removed that and will rerun the tests. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24222 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aq2lOC4_apfrJxD7MW6BLq2CJP126r1Iks5u6BhegaJpZM4ZI_Co> .

hshankar61 · 2018-12-19T06:33:54Z

The previous errors were for Windows but now the MacOS and Ubuntu builds show errors. None of the errors are related to the files I checked in. So how does one make this process converge?

gunan · 2018-12-19T06:38:01Z

There were build breakages merged to master branch.
Now they are fixed, I will retrigger your tests.

hshankar61 · 2018-12-19T07:21:34Z

Thanks. This time the "MacOS Contrib" check has failed as earlier, but the "Ubuntu contrib" test which passed before now fails. But two of the earlier checks that failed, now pass ("MacOS Python2" and "Ubuntu Python3").

PiperOrigin-RevId: 226966660

New files for Tensorflow Lite Micro Speech Example targetting the Eta…

fc19d28

… Compute ECM3531 evaluation board

googlebot added the cla: no label Dec 7, 2018

petewarden reviewed Dec 10, 2018

View reviewed changes

hari added 6 commits December 10, 2018 11:55

fixed grammer

9192d06

conform to Google coding standards

374ad6b

conform to Google coding standards

6042bbb

added copyright statement

7fbd071

added copyright statement and comment for usage

ac0d13b

added brief comment about this file

6f5e6dc

petewarden previously approved these changes Dec 10, 2018

View reviewed changes

googlebot added cla: yes and removed cla: no labels Dec 13, 2018

gunan added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 14, 2018

kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 14, 2018

petewarden added the kokoro:force-run Tests on submitted change label Dec 17, 2018

kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 17, 2018

Delete test_ecm3531_binary.sh

3eb35ec

Causes a missing-copyright error on internal verification

petewarden dismissed their stale review via 3eb35ec December 17, 2018 22:13

petewarden approved these changes Dec 17, 2018

View reviewed changes

gunan assigned Harshini-Gadige and ymodak Dec 17, 2018

petewarden added the kokoro:force-run Tests on submitted change label Dec 18, 2018

kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 18, 2018

petewarden added the kokoro:force-run Tests on submitted change label Dec 18, 2018

kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 18, 2018

gunan added the kokoro:force-run Tests on submitted change label Dec 19, 2018

kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 19, 2018

petewarden added the kokoro:force-run Tests on submitted change label Dec 19, 2018

kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 19, 2018

tensorflow-copybara merged commit 3eb35ec into tensorflow:master Dec 27, 2018

tensorflow-copybara pushed a commit that referenced this pull request Dec 27, 2018

Merge pull request #24222 from hshankar61:master

9fbf026

PiperOrigin-RevId: 226966660

		@@ -0,0 +1,97 @@
		/*******************************************************************************
		* Copyright (C) 2018 Eta Compute, Inc

	* Copyright (C) 2018 Eta Compute, Inc
	* Copyright 2018 The TensorFlow Authors. All Rights Reserved.

-#!/usr/bin/python3
+#!/usr/bin/python3
+# Copyright 2015 The TensorFlow Authors. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ==============================================================================

		#include "memio.h"


		//#pragma GCC optimize ("align-functions=16")

New files for Tensorflow Lite Micro Speech Example targetting the Eta… #24222

New files for Tensorflow Lite Micro Speech Example targetting the Eta… #24222

Conversation

hshankar61 commented Dec 7, 2018

googlebot commented Dec 7, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

hshankar61 commented Dec 7, 2018 via email

hshankar61 commented Dec 9, 2018

petewarden left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hshankar61 commented Dec 13, 2018

googlebot commented Dec 13, 2018

petewarden commented Dec 14, 2018

petewarden commented Dec 17, 2018

hshankar61 commented Dec 17, 2018 via email

petewarden commented Dec 17, 2018

hshankar61 commented Dec 17, 2018

petewarden commented Dec 17, 2018

hshankar61 commented Dec 17, 2018

petewarden commented Dec 17, 2018

hshankar61 commented Dec 18, 2018

hshankar61 commented Dec 18, 2018 via email

hshankar61 commented Dec 19, 2018

gunan commented Dec 19, 2018

hshankar61 commented Dec 19, 2018