cloud oauth_client: update for OpenSSL 1.1.0 compatibility #24666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harshini-Gadige
added
awaiting review
|
Related Gentoo bug: https://bugs.gentoo.org/673968 |
penpornk
requested changes
Jan 3, 2019
There was a problem hiding this comment.
Thank you for the fix!
Could you please add comments near the EVP_MD_CTX_destroy calls that EVP_MD_CTX_destroy is renamed to EVP_MD_CTX_free in OpenSSL 1.1.0 but the old name is still retained as macro; and maybe add a link to the change notes? Just for reference.
penpornk
added
kokoro:force-run
EVP_MD_CTX_cleanup was removed in OpenSSL 1.1.0. There is a call to EVP_MD_CTX_destroy right after and _destroy will call _cleanup if required. EVP_MD_CTX_destroy exists in OpenSSL 1.0, 1.1 and BoringSSL so removing the call to _cleanup works everywhere. Signed-off-by: Jason Zaman <jason@perfinion.com>
|
@penpornk Good idea, I pushed an update with the comment and a note to not change it till support is dropped for 1.0.x. |
penpornk
approved these changes
Jan 5, 2019
Harshini-Gadige
added
kokoro:force-run
Harshini-Gadige
added
ready to pull
tensorflow-copybara
pushed a commit
that referenced
this pull request
Jan 7, 2019
PiperOrigin-RevId: 228214198
This was referenced Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVP_MD_CTX_cleanup was removed in OpenSSL 1.1.0. There is a call to
EVP_MD_CTX_destroy right after and _destroy will call _cleanup if
required. EVP_MD_CTX_destroy exists in OpenSSL 1.0, 1.1 and BoringSSL so
removing the call to _cleanup works everywhere.
Signed-off-by: Jason Zaman jason@perfinion.com