-
Notifications
You must be signed in to change notification settings - Fork 74.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix import of tools/bazel.rc for Bazel 0.19.0 or later #25114
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@SimonBoorer Can you please sign the cla to move ahead with this PR? Thanks! |
tools/bazel.rc doesn't exist any more (in the master branch). It was moved to .bazelrc in the workspace root so that bazel will automatically pick it up. |
What version of TF is this for? as @wdirons said, tools/bazel.rc is gone and moved to .bazelrc. The minimum version of bazel is also set to the right versions so everything is fine. TF1.13 also has this fixed. If this is for an older version it should be for those branches but i dont think there are going to be any more releases of 1.12 either. |
There is going to be a 1.12.1 at least, I'll prepare it in a few weeks |
@SimonBoorer Please sign the cla to move ahead with this PR. Thanks! |
This should not be merged into master, as there is no issue there |
@mihaimaruseac what should be the next step here? Should we close this PR? |
I think it should be rebased on the branches which have the issue (probably at least v1.12). Or closed and reopened if needed |
This was removed in https://github.com/tensorflow/tensorflow/pull/22964/files which causes build errors with bazel 0.20.0 because tools/bazel.rc is ignored so the grpc_no_ares=true flag doesn't get set and grpc is compiled with c-ares support:
Re-adding this line fixes the issue.