Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of tools/bazel.rc for Bazel 0.19.0 or later #25114

Closed
wants to merge 1 commit into from
Closed

Fix import of tools/bazel.rc for Bazel 0.19.0 or later #25114

wants to merge 1 commit into from

Conversation

SimonBoorer
Copy link

This was removed in https://github.com/tensorflow/tensorflow/pull/22964/files which causes build errors with bazel 0.20.0 because tools/bazel.rc is ignored so the grpc_no_ares=true flag doesn't get set and grpc is compiled with c-ares support:

ERROR: /user_data/.tmp/cache.srbo/bazel/_bazel_srbo/96431eb3bb8da25a1741c1c1ac91e19b/external/grpc/BUILD:1332:1: C++ compilation of rule '@grpc//:grpc_resolver_dns_ares' failed (Exit 1) gcc failed: error executing command /builds/gcc/4.9.4/12a8bec7dd/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG ... (remaining 56 argument(s) skipped) 

  

Use --sandbox_debug to see verbose messages from the sandbox 

external/grpc/src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc:30:18: fatal error: ares.h: No such file or directory 

#include <ares.h> 

                  ^ 

compilation terminated. 

Target //tensorflow/tools/pip_package:build_pip_package failed to build 

Use --verbose_failures to see the command lines of failed build steps. 

INFO: Elapsed time: 98.819s, Critical Path: 17.24s 

INFO: 750 processes: 2 local, 748 processwrapper-sandbox. 

FAILED: Build did NOT complete successfully

Re-adding this line fixes the issue.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@ymodak
Copy link
Contributor

ymodak commented Jan 22, 2019

@SimonBoorer Can you please sign the cla to move ahead with this PR? Thanks!

@wdirons
Copy link
Contributor

wdirons commented Jan 24, 2019

tools/bazel.rc doesn't exist any more (in the master branch). It was moved to .bazelrc in the workspace root so that bazel will automatically pick it up.

@pragyaak pragyaak self-assigned this Feb 1, 2019
@pragyaak pragyaak requested review from perfinion and removed request for perfinion February 1, 2019 22:11
@perfinion
Copy link
Member

What version of TF is this for? as @wdirons said, tools/bazel.rc is gone and moved to .bazelrc. The minimum version of bazel is also set to the right versions so everything is fine. TF1.13 also has this fixed. If this is for an older version it should be for those branches but i dont think there are going to be any more releases of 1.12 either.

@mihaimaruseac
Copy link
Collaborator

There is going to be a 1.12.1 at least, I'll prepare it in a few weeks

@pragyaak
Copy link

pragyaak commented Feb 5, 2019

@SimonBoorer Please sign the cla to move ahead with this PR. Thanks!

@mihaimaruseac
Copy link
Collaborator

mihaimaruseac commented Feb 5, 2019

This should not be merged into master, as there is no issue there

@pragyaak
Copy link

pragyaak commented Feb 5, 2019

@mihaimaruseac what should be the next step here? Should we close this PR?

@mihaimaruseac
Copy link
Collaborator

I think it should be rebased on the branches which have the issue (probably at least v1.12). Or closed and reopened if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants