Added the Padding and Activation scenarios #26062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rthadur
added
awaiting review
|
Nagging Reviewer @aselle: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 14 days with no activity and the |
haozha111
reviewed
Mar 12, 2019
amitsrivastava78
force-pushed
the
pooling_tc_1
branch
from
7a5b449
to
ac11136
Compare
|
@haozha111 , thanks for pointing this out, i have made the changes as suggested by you, kindly check and approve. |
amitsrivastava78
force-pushed
the
pooling_tc_1
branch
from
ac11136
to
a133e13
Compare
haozha111
reviewed
Mar 13, 2019
amitsrivastava78
force-pushed
the
pooling_tc_1
branch
from
a133e13
to
0c0ce61
Compare
|
@haozha111 Sure, made the change as per the comments, kindly check and approve |
haozha111
reviewed
Mar 14, 2019
amitsrivastava78
force-pushed
the
pooling_tc_1
branch
from
0c0ce61
to
054e084
Compare
|
@haozha111 , thanks for the feedback, i have updated the code as per your suggestion. Kindly check and approave. |
haozha111
reviewed
Mar 14, 2019
amitsrivastava78
force-pushed
the
pooling_tc_1
branch
from
054e084
to
df55aca
Compare
|
@haozha111 , sorry for the overlook, i have fixed the issue, kindly check and approve. |
haozha111
reviewed
Mar 17, 2019
haozha111
reviewed
Mar 17, 2019
This was one of the TODO items
amitsrivastava78
force-pushed
the
pooling_tc_1
branch
from
df55aca
to
6eb82aa
Compare
|
@haozha111 , I have updated the code as per the suggestions, kindly check and approve, Regards |
haozha111
approved these changes
Mar 17, 2019
rthadur
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Mar 18, 2019
PiperOrigin-RevId: 239055830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was one of the TODO items