Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_pool_with_argmax GPU kernel supports include_batch_in_index #26562

Merged
merged 4 commits into from
Mar 12, 2019
Merged

max_pool_with_argmax GPU kernel supports include_batch_in_index #26562

merged 4 commits into from
Mar 12, 2019

Conversation

facaiy
Copy link
Member

@facaiy facaiy commented Mar 11, 2019 •
edited

Fix #22025, #24067

Related PR: #25241, #23993

@facaiy facaiy mentioned this pull request Mar 11, 2019
Closed
@facaiy facaiy requested review from reedwm and alextp and removed request for alextp and reedwm March 11, 2019 06:37
@facaiy facaiy added this to Assigned Reviewer in PR Queue via automation Mar 11, 2019
@facaiy facaiy requested review from reedwm and alextp March 11, 2019 06:39
@facaiy facaiy added size:M CL Change Size: Medium awaiting review Pull request awaiting review labels Mar 11, 2019
@facaiy
Copy link
Member Author

facaiy commented Mar 11, 2019

@reedwm @alextp Hi, Reed, Alexandre, could you take a look? Thanks.

@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Mar 12, 2019
alextp
alextp approved these changes Mar 12, 2019
View reviewed changes
tensorflow/python/kernel_tests/pooling_ops_test.py
# GPU
[True, False, [0, 1, 3, 5, 0, 2, 6, 8]],
[True, True, [0, 1, 3, 5, 9, 11, 15, 17]]
Config(False, False, [0, 1, 3, 5, 0, 2, 6, 8]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you have a namedtuple you can use kwargs here to make it prettier

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 12, 2019
@rthadur rthadur added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 12, 2019
@tensorflow-copybara tensorflow-copybara merged commit 5e87bf5 into tensorflow:master Mar 12, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Mar 12, 2019
tensorflow-copybara pushed a commit that referenced this pull request Mar 12, 2019
@tensorflower-gardener
Merge pull request #26562 from facaiy:ENH/max_pool_with_argmax_gpu_su…
d80a3bb 
…pport_include_batch_in_index

PiperOrigin-RevId: 238114414
@facaiy facaiy deleted the ENH/max_pool_with_argmax_gpu_support_include_batch_in_index branch March 13, 2019 00:24
@facaiy facaiy mentioned this pull request Mar 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextp alextp alextp approved these changes

@reedwm reedwm Awaiting requested review from reedwm

Assignees

@rthadur rthadur

Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@facaiy @alextp @googlebot @kokoro-team @tensorflowbutler @tensorflow-copybara @rthadur