Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lite: Split_V test cases improvised #26575

Merged
merged 2 commits into from Mar 13, 2019
Merged

Lite: Split_V test cases improvised #26575

merged 2 commits into from Mar 13, 2019

Conversation

ANSHUMAN87
Copy link
Contributor

1:> Test cases improvised to support 2 more datatypes.
2:> Error message improvised.

shahzadlone
shahzadlone previously approved these changes Mar 11, 2019
View reviewed changes
@rthadur rthadur self-assigned this Mar 11, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 11, 2019
@rthadur rthadur added awaiting review Pull request awaiting review size:M CL Change Size: Medium labels Mar 11, 2019
@rthadur rthadur requested a review from haozha111 March 11, 2019 21:55
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Mar 12, 2019
haozha111
haozha111 approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@haozha111 haozha111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your changes!

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Mar 12, 2019
@haozha111 haozha111 self-requested a review March 12, 2019 15:07
@rthadur rthadur added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review labels Mar 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 12, 2019
@tensorflow-copybara tensorflow-copybara merged commit d5655b8 into tensorflow:master Mar 13, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Mar 13, 2019
tensorflow-copybara pushed a commit that referenced this pull request Mar 13, 2019
@tensorflower-gardener
Merge pull request #26575 from ANSHUMAN87:split_v-test-improve
be7d219 
PiperOrigin-RevId: 238254978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haozha111 haozha111 haozha111 approved these changes

@shahzadlone shahzadlone shahzadlone left review comments

Assignees

@rthadur rthadur

Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ANSHUMAN87 @haozha111 @shahzadlone @googlebot @kokoro-team @tensorflow-copybara @rthadur