Remove a few warnings on macOS #26675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove unused captures in lambdas. 2. Reorder a field initializer list. 3. Remove some unused typedefs. 4. Remove a few unused variables. Many warnings remain, including many thread safety warnings which are somewhat alarming.
rthadur
added
awaiting review
jsimsa
previously approved these changes
Mar 14, 2019
|
@jsimsa Am I correct that the Windows failure is unrelated? Not sure about the copybara one. |
|
Correct, the Windows failure seems unrelated. The copybara one tracks the status of the internal review that should get kicked off by @rthadur shortly. |
rthadur
added
kokoro:force-run
jsimsa
reviewed
Mar 14, 2019
| @@ -14,6 +14,7 @@ limitations under the License. | |||
| ==============================================================================*/ | |||
| #include "tensorflow/core/kernels/data/stats_utils.h" | |||
|
|
|||
| #include "absl/base/attributes.h" | |||
There was a problem hiding this comment.
Internally, I am seeing an error that indicates that tensorflow/core/kernels/data:stats_utils does not depend on a module exporting third_party/absl/base/attributes.h. Could you please fix that? Thanks.
Closed
|
@jsimsa What's the next step here? |
jsimsa
approved these changes
Mar 20, 2019
rthadur
added
ready to pull
tensorflow-copybara
pushed a commit
that referenced
this pull request
Mar 21, 2019
PiperOrigin-RevId: 239696002
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many warnings remain, including many thread safety warnings which are
somewhat alarming.