Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct API docs for tf.io.decode_gif #26773

Merged
merged 2 commits into from
Mar 21, 2019

Conversation

frreiss
Copy link
Contributor

@frreiss frreiss commented Mar 15, 2019

The API docs for tf.io.decode_gif currently state that the op only decodes the first frame of animated GIFs. But the C++ implementation actually extracts all frames from animated GIF files; see code here.

This PR corrects the API docs to match the implementation.

@rthadur rthadur self-assigned this Mar 18, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 18, 2019
@rthadur rthadur added awaiting review Pull request awaiting review comp:apis Highlevel API related issues size:XS CL Change Size: Extra Small labels Mar 18, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 18, 2019
Copy link
Member

@martinwicke martinwicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than linter comment, looks good.

tensorflow/core/api_def/base_api/api_def_DecodeGif.pbtxt Outdated Show resolved Hide resolved
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Mar 18, 2019
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Mar 19, 2019
Fix errors in previous commit.
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Mar 21, 2019
@rthadur rthadur added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 21, 2019
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Mar 21, 2019
@tensorflow-copybara tensorflow-copybara merged commit 4ec36aa into tensorflow:master Mar 21, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Mar 21, 2019
tensorflow-copybara pushed a commit that referenced this pull request Mar 21, 2019
@frreiss frreiss deleted the issue-gif-shape branch May 9, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:apis Highlevel API related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants