Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sentence about usage of rmsprop for RNN #26993

Merged
merged 1 commit into from
Apr 6, 2019
Merged

remove sentence about usage of rmsprop for RNN #26993

merged 1 commit into from
Apr 6, 2019

Conversation

chie8842
Copy link

There is not enough evidence for the following sentence.

This optimizer is usually a good choice for recurrent
neural networks.

@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 21, 2019
@rthadur rthadur added comp:keras Keras related issues size:XS CL Change Size: Extra Small labels Mar 21, 2019
@rthadur rthadur self-assigned this Mar 21, 2019
@rthadur rthadur requested a review from fchollet March 21, 2019 18:08
@gbaned gbaned requested a review from tanzhenyu April 5, 2019 05:12
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 5, 2019
@rthadur rthadur added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 5, 2019
@tensorflow-copybara tensorflow-copybara merged commit 8cc3c1f into tensorflow:master Apr 6, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 6, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 6, 2019
@tensorflower-gardener
Merge pull request #26993 from chie8842:change_rmsprop_doc
22b3262 
PiperOrigin-RevId: 242221932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanzhenyu tanzhenyu tanzhenyu approved these changes

@fchollet fchollet Awaiting requested review from fchollet

Assignees

@rthadur rthadur

Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chie8842 @tanzhenyu @googlebot @kokoro-team @tensorflow-copybara @rthadur