Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tflite/tools/make: remove bashism #27235

Merged
merged 1 commit into from May 13, 2019

Conversation

proppy
Copy link
Contributor

@proppy proppy commented Mar 28, 2019

This should fix the following error when attempting to compile tflite on platform where bash is not the default shell:

/bin/sh: 1: [[: not found

/cc @dansitu

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 28, 2019
@gbaned gbaned added comp:lite TF Lite related issues size:XS CL Change Size: Extra Small labels Mar 28, 2019
@gbaned gbaned requested a review from renjie-liu March 28, 2019 07:57
@renjie-liu renjie-liu requested review from miaout17 and removed request for renjie-liu March 28, 2019 07:59
@gbaned
Copy link
Contributor

gbaned commented Apr 25, 2019

@miaout17 Could you PTAL and approve.

@gbaned gbaned added the awaiting review Pull request awaiting review label Apr 25, 2019
@gbaned gbaned requested a review from renjie-liu May 10, 2019 09:47
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer May 10, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 10, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 10, 2019
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label May 11, 2019
@tensorflow-copybara tensorflow-copybara merged commit 223bfa3 into tensorflow:master May 13, 2019
PR Queue automation moved this from Approved by Reviewer to Merged May 13, 2019
pull bot pushed a commit to Pandinosaurus/tensorflow that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:lite TF Lite related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

8 participants