Updated docs formatting #27588
Merged
Updated docs formatting #27588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf.feature_column.categorical_column_with_vocabulary_file defined in python/feature_column/feature_column_v2.py.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
rthadur
requested review from
mihaimaruseac and
rohan100jain
and removed request for
mihaimaruseac
|
@neighlyd thanks for your contribution, please sign CLA |
dynamicwebpaige
previously approved these changes
Apr 8, 2019
mihaimaruseac
approved these changes
Apr 8, 2019
|
@neighlyd gentle ping to sign CLA |
|
I signed it this morning!
…On Sat, Apr 6, 2019 at 12:54 PM googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here (e.g. I
signed it!) and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google.com/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
ℹ️ *Googlers: Go here
<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Ftensorflow%2Ftensorflow%2Fpull%2F27588>
for more info*.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27588 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIrDh-UKDvj2VqQ7N35Yyu9mOyN0Z2Izks5vePtXgaJpZM4cgYpl>
.
|
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
I apologize, it looks like I hadn't replied to the googlebot's CLA message! I went ahead and did that. |
rthadur
added
kokoro:force-run
mihaimaruseac
requested changes
Apr 10, 2019
| File '/us/states.txt' contains 51 lines - the first line is 'XX', and the | ||
| other 50 each have a 2-character U.S. state abbreviation. Both a literal 'XX' | ||
| File `'/us/states.txt'` contains 51 lines - the first line is `'XX'`, and the | ||
| other 50 each have a 2-character U.S. state abbreviation. Both a literal `'XX'` |
There was a problem hiding this comment.
Linter reports error here
FAIL: Found 1 non-whitelited pylint errors:
tensorflow/python/feature_column/feature_column_v2.py:1608: [C0301(line-too-long), ] Line too long (81/80)
Fixed line lengths
mihaimaruseac
added
ready to pull
tensorflow-copybara
pushed a commit
that referenced
this pull request
Apr 11, 2019
PiperOrigin-RevId: 243122021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf.feature_column.categorical_column_with_vocabulary_file defined in python/feature_column/feature_column_v2.py.