Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup & TC added l2_norm graph transformation. #27616

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

amitsrivastava78
Copy link
Contributor

@amitsrivastava78 amitsrivastava78 commented Apr 8, 2019

Clean-up: replace FindOperator with FindOp and add missing unit tests
for the l2_norm graph transformation.

@gbaned gbaned added comp:lite TF Lite related issues size:M CL Change Size: Medium labels Apr 8, 2019
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 8, 2019
@multiverse-tf
Copy link
Contributor

Change the commit description to be more specific? Like "Clean-up: replace FindOperator with FindOp and add missing unit tests for the l2_norm graph transformation"?

Clean-up: replace FindOperator with FindOp and add missing unit tests
for the l2_norm graph transformation.
@amitsrivastava78 amitsrivastava78 changed the title Bug fix for l2_norm graph transformation. Cleanup & TC added l2_norm graph transformation. Apr 8, 2019
@amitsrivastava78
Copy link
Contributor Author

@multiverse-tf , thanks for the review i have updated as per your suggestion, kindly check.

Regards
Amit

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 10, 2019
@amitsrivastava78
Copy link
Contributor Author

@multiverse-tf , thanks for approving the PR.
@gbaned , @rthadur please change the PR label to approved.

Regards
Amit

@amitsrivastava78
Copy link
Contributor Author

@miaout17 , can you please review the PR and provide your feedback.

Regards
Amit

@rthadur rthadur added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 17, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 17, 2019
@tensorflow-copybara tensorflow-copybara merged commit 7c94871 into tensorflow:master Apr 24, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 24, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:lite TF Lite related issues ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants