Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative axis issue with ragged tensor and reduce_sum #27699

Merged
merged 2 commits into from Apr 18, 2019
Merged

Fix negative axis issue with ragged tensor and reduce_sum #27699

merged 2 commits into from Apr 18, 2019

Commits on Apr 10, 2019

  1. Fix negative axis issue with ragged tensor and reduce_sum 

    This fix tries to address the issue raised in 27497 where
`tf.reduce_sum` with multiple negative axes and ragged tensor
does not produce correct result.

The issue is that during reduce op, ragged tensor will reduce
one axis at a time. However, for negative axis, sort result is
reversed so order is different.

This fix convert to positive before the sort to make sure
the order.

This fix fixes 27497.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    82eafde View commit details
    Browse the repository at this point in the history

  2. Add test case for GitHub issue 27497 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    f303882 View commit details
    Browse the repository at this point in the history