Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysconfig: fix library name on macos #27865

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

perfinion
Copy link
Member

On darwin, the library is named libtensorflow_framework.2.dylib

Signed-off-by: Jason Zaman jason@perfinion.com

On darwin, the library is named libtensorflow_framework.2.dylib

Signed-off-by: Jason Zaman <jason@perfinion.com>
@angerson
Copy link
Contributor

Finally resolves #27430 (where it was noted that MacOS is failing to build).

Copy link
Contributor

@angerson angerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@angerson angerson added the ready to pull PR ready for merge process label Apr 15, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Apr 15, 2019
@rthadur rthadur self-assigned this Apr 15, 2019
@rthadur rthadur added the size:XS CL Change Size: Extra Small label Apr 15, 2019
@tensorflow-copybara tensorflow-copybara merged commit e2994c0 into tensorflow:master Apr 15, 2019
PR Queue automation moved this from Assigned Reviewer to Merged Apr 15, 2019
@perfinion perfinion deleted the sysconfig branch April 16, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants