New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
find_cuda: fix crash caused by unicode chars in ldconfig output #28209
Conversation
This line also fixed it for me, don't know if it is a (more?) generic one: |
Yes, that would fix the encoding generally. So I would be happy with this too. 4403 Bibliotheken im Cache »/etc/ld.so.cache« gefunden
libzvbi.so.0 (libc6,x86-64) => /usr/lib/libzvbi.so.0
.... E.g. for German locale, the chars |
Yes, that was probably also the case in my case ;) Funnily only when calling ./configure from the command line, not when executing the code in ipython or spyder. |
@skye can you please review this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the one comment.
UnicodeDecodeError added.
PiperOrigin-RevId: 249072380
find_cuda_config.py
crashes, if Unicode chars are found inldconfig
output:Localized versions of
ldconfig
versions use Unicode chars, e.g.:»/etc/ld.so.cache«
, causing the crash.The fix simply skips lines with Unicode chars.