Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tf.image.ssim_multiscale execution issue #28274

Merged
merged 2 commits into from
Apr 30, 2019

Conversation

yongtang
Copy link
Member

This fix tries to address the issue raised in #28241 where tf.image.ssim_multiscale will throw out error if the input is numpy array instead of tensor.

This fix adds the conversion (also removed duplicated shape checking).

This fix fixes #28241.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

This fix tries to address the issue raised in 28241 where
tf.image.ssim_multiscale will throw out error if the input
is numpy array instead of tensor.

This fix adds the conversion (also removed duplicated shape checking).

This fix fixes 28241.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Apr 30, 2019
@rthadur rthadur self-assigned this Apr 30, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Apr 30, 2019
@rthadur rthadur added the prtype:bugfix PR to fix a bug label Apr 30, 2019
@rthadur rthadur requested a review from alextp April 30, 2019 02:19
@rthadur rthadur added the comp:ops OPs related issues label Apr 30, 2019
Copy link
Contributor

@alextp alextp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 30, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 30, 2019
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Apr 30, 2019
pull bot pushed a commit to Rachelmorrell/tensorflow that referenced this pull request Apr 30, 2019
@tensorflow-copybara tensorflow-copybara merged commit 457f1c1 into tensorflow:master Apr 30, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 30, 2019
@yongtang yongtang deleted the 28241-ssim_multiscale branch April 30, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:ops OPs related issues prtype:bugfix PR to fix a bug ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

tf.image and eager execution bug
6 participants