[ROCm] Fix for the broken --config=rocm build.
#28370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --config=rocm build was broken by the following commit. tensorflow@084e14e The changes made by the above commit did not contain the corresponding changes for the ROCm platform, which was leading to the build failure. Making the corresponding update for ROCm, to make the --config=rocm build working again.
whchung
approved these changes
May 3, 2019
timshen91
approved these changes
May 3, 2019
pull bot
pushed a commit
to Rachelmorrell/tensorflow
that referenced
this pull request
May 3, 2019
…upstream_rocm_platform_fix_190503 PiperOrigin-RevId: 246566754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --config=rocm build was broken by the following commit.
084e14e
The changes made by the above commit did not contain the corresponding changes for the ROCm platform, which was leading to the build failure. Making the corresponding update for ROCm, to make the --config=rocm build working again.
@tatianashp , @whchung, @timshen91 just FYI
Please approve and merge. As with other such PRs this week, the changes here are trivial and only applicable for the --config=rocm build.
thanks