[ROCm] Adding ROm support for "concat", "pack", "unpack" and "split" ops

[deven-amd]

This PR add ROCm support for "concat", "pack", "unpack" and "split" ops

PR #28343 is a pre-req for this PR, and hence this PR includes commits from PR #28343
Only the last three commits in this PR is exclusive to this PR, and hence should be the only one reviewed.

---

Please ignore the cla check failure...that is getting triggered because this PR builds on top of PR #28343 (which is submitted by a different developer). Once that PR is merged, and I rebase this PR, the commit triggering the cla check failure will be gone from this commit

---

@tatianashp , @whchung : just FYI

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

[timshen91]

@chsigg , would you be able to take a look at this and PR 28450 as they are TF implementation changes?

[chsigg]

Please do not rename the symbols or macros as part of this PR. This is better done from our end, because of internal dependencies that you cannot update.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[deven-amd]

@chsigg

rebased this PR now that the updates related to Cuda* to Gpu* renaming are merged into master.

This PR is now trivial, please review and merge.

thanks

[deven-amd]

The failures in the LInux GPU CI run are due to the fact that PR #28834 is not yet merged.

PR #28834 renames the cuda_helper namespace to gpu_helper (an alias cuda_helper is also introduced for backward compatbility).

This PR updates the the cuda_helper reference to gpu_helper (since the cuda_helper name is not visible in ROCm builds). Please re-run CI after PR #28834 is merged, that should get rid of the errors.

thanks

[chsigg]

Remove extra parenthesis. Here and below.

[deven-amd]

let me do that and push out a rebase

[chsigg]

Does ROCm's dim3 not implicitly construct from int?

[deven-amd]

it does...the dim3 call does not need to be there...will remove it along with the extra parens

[chsigg]

Yes, we can address the dynamic shared memory in a separate change.

…

On Thu, May 23, 2019, 20:59 Rajeshwar Reddy T ***@***.***> wrote: @rthadur <https://github.com/rthadur> requested your review on: #28451 <#28451> [ROCm] Adding ROm support for "concat", "pack", "unpack" and "split" ops. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#28451?email_source=notifications&email_token=ABZM5DRAVB5UBLKOAMVN2Q3PW3SPXA5CNFSM4HLDPJDKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORTPWNTA#event-2363451084>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZM5DVULTNHLG56LCHCHXDPW3SPXANCNFSM4HLDPJDA> .