Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Creating GpuLaunchKernel #28565

Closed
wants to merge 1 commit into from
Closed

[ROCm] Creating GpuLaunchKernel #28565

wants to merge 1 commit into from

Conversation

jerryyin
Copy link
Member

@jerryyin jerryyin commented May 9, 2019

This PR is a follow-up to the original PR #28343. The reviewer requested to break down the original large PR to a series of smaller ones. According to the plan here, this PR is the fifth one in the whole series.

@chsigg @whchung

@tensorflow-bot tensorflow-bot bot added the size:M CL Change Size: Medium label May 9, 2019
@jerryyin jerryyin mentioned this pull request May 9, 2019
Closed
@jerryyin jerryyin changed the title Creating GpuLaunchKernel [ROCm] Creating GpuLaunchKernel May 9, 2019
@whchung whchung requested a review from chsigg May 9, 2019 20:40
@whchung whchung added the kokoro:force-run Tests on submitted change label May 9, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 9, 2019
@rthadur rthadur self-assigned this May 9, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation May 9, 2019
@rthadur rthadur requested review from chsigg and removed request for chsigg May 9, 2019 22:23
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer May 13, 2019
chsigg
chsigg previously approved these changes May 13, 2019
View reviewed changes
tensorflow/core/util/gpu_kernel_helper.h Outdated Show resolved Hide resolved
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 13, 2019
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes May 13, 2019
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels May 13, 2019
@jerryyin jerryyin force-pushed the google-upstream-pr-GpuLaunchKernel branch from c4756f5 to d970eeb Compare May 13, 2019 18:40
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes May 13, 2019
@rthadur rthadur requested a review from chsigg May 13, 2019 18:48
@whchung whchung added kokoro:force-run Tests on submitted change and removed kokoro:force-run Tests on submitted change labels May 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 13, 2019
@rthadur rthadur removed the ready to pull PR ready for merge process label May 13, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@jerryyin jerryyin force-pushed the google-upstream-pr-GpuLaunchKernel branch from ef40ecd to 50a958e Compare May 13, 2019 21:13
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@whchung whchung added the kokoro:force-run Tests on submitted change label May 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 13, 2019
tensorflow-copybara pushed a commit that referenced this pull request May 13, 2019
@tensorflower-gardener
PR #28565: [ROCm] Creating GpuLaunchKernel
921ee23 
Imported from GitHub PR #28565

This PR is a follow-up to the original PR #28343. The reviewer requested to break down the original large PR to a series of smaller ones. According to the plan here, this PR is the fifth one in the whole series.

@chsigg @whchung

Copybara import of the project:

  - c4756f5 Creating GpuLaunchKernel by zhuoryin <zhuoryin@amd.com>
  - bd98ac6 Merge c4756f5 into b5170... by Zhuoran Yin <jerryyin@users.noreply.github.com>

COPYBARA_INTEGRATE_REVIEW=#28565 from ROCmSoftwarePlatform:google-upstream-pr-GpuLaunchKernel c4756f5
PiperOrigin-RevId: 248006235
@jerryyin
Copy link
Member Author

It looks like this PR is already merged here, but github is not showing it correctly. I'm not entirely sure what repercussion will have if I close PR, so will just leave it. FYI, @chsigg @whchung,

@whchung
Copy link
Contributor

whchung commented May 14, 2019

@jerryyin you should be able to close this PR without causing trouble on the mainline.

@jerryyin jerryyin closed this May 14, 2019
PR Queue automation moved this from Reviewer Requested Changes to Closed/Rejected May 14, 2019
@deven-amd deven-amd mentioned this pull request May 30, 2019
Merged
@jerryyin jerryyin deleted the google-upstream-pr-GpuLaunchKernel branch December 20, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsigg chsigg Awaiting requested review from chsigg

Assignees

@rthadur rthadur

Labels
cla: yes size:M CL Change Size: Medium
Projects
PR Queue
  
Closed/Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jerryyin @googlebot @whchung @chsigg @kokoro-team @rthadur