Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build_def.bzl #29515

Closed
wants to merge 1 commit into from
Closed

Update build_def.bzl #29515

wants to merge 1 commit into from

Conversation

leonard951
Copy link
Contributor

To resolve the following two issues on a linux_aarch64 system:

  1. prohibited conversions between vectors (Error building Tensorflow Lite on AARCH64 #26731 (comment))
  2. prohibited explicit use of frame pointer register x29 in asm (Error building Tensorflow Lite on AARCH64 #26731 (comment))

@leonard951
Update build_def.bzl
be25ae6 
To resolve the following two issues on a linux_aarch64 system:
1. prohibited conversions between vectors (tensorflow#26731 (comment))
2. prohibited explicit use of frame pointer register x29 in asm (tensorflow#26731 (comment))
@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Jun 6, 2019
@leonard951 leonard951 mentioned this pull request Jun 6, 2019
Closed
@rthadur rthadur self-assigned this Jun 6, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jun 6, 2019
@rthadur rthadur added the comp:lite TF Lite related issues label Jun 6, 2019
@rthadur rthadur requested a review from petewarden June 6, 2019 22:33
@leonard951
Copy link
Contributor Author

Hi petewarden, could you review the code change at your convenience?

@jdduke jdduke requested a review from renjie-liu June 17, 2019 20:28
renjie-liu
renjie-liu reviewed Jun 18, 2019
View reviewed changes
Copy link
Member

@renjie-liu renjie-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr, however strict enforcement can help us catch potential bugs.

we're working on fixing the compilation issue.

@petewarden
Copy link
Contributor

It looks like the underlying #26731 is fixed, so I'm assuming we can close this now?

@petewarden petewarden closed this Aug 1, 2019
PR Queue automation moved this from Assigned Reviewer to Closed/Rejected Aug 1, 2019
@Flamefire Flamefire mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renjie-liu renjie-liu renjie-liu left review comments

@petewarden petewarden Awaiting requested review from petewarden

Assignees

@rthadur rthadur

Labels
cla: yes comp:lite TF Lite related issues size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Closed/Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leonard951 @petewarden @renjie-liu @googlebot @rthadur