Fix grad of variable size on extract_image_patches #29815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextp
suggested changes
Jun 17, 2019
alextp
approved these changes
Jun 17, 2019
tensorflow-bot
bot
added
kokoro:force-run
|
@rthadur Is it possible this PR to be included with 1.14? |
|
Sadly no, 1.14 is about to be released.
…On Tue, Jun 18, 2019, 06:51 Vasileios Lioutas ***@***.***> wrote:
@rthadur <https://github.com/rthadur> Is it possible this PR to be
included with 1.14?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#29815?email_source=notifications&email_token=AAABHROMUBPLFHLJMYCD7PTP3DR63A5CNFSM4HYOFJOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX6VCXY#issuecomment-503140703>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABHRM7VWLBHNGQA457T73P3DR63ANCNFSM4HYOFJOA>
.
|
|
@alextp Okay thank you for letting me know. |
alextp
suggested changes
Jun 18, 2019
tensorflow/python/kernel_tests/extract_image_patches_grad_test.py
Outdated
Show resolved
Hide resolved
|
Yes
…On Tue, Jun 18, 2019 at 1:12 PM Vasileios Lioutas ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tensorflow/python/kernel_tests/extract_image_patches_grad_test.py
<#29815 (comment)>
:
> + in_val = array_ops.placeholder(
+ shape=test_shape,
+ dtype=dtypes.float32)
+
+ feed_dict = {in_val: np.random.random(in_shape)}
+ for padding in ['VALID', 'SAME']:
+ out_val = array_ops.extract_image_patches(in_val, test_case['ksizes'],
+ test_case['strides'],
+ test_case['rates'], padding)
+ out_val_tmp = out_val.eval(feed_dict=feed_dict)
+ out_shape = out_val_tmp.shape
+
+ err = gradient_checker.compute_gradient_error(in_val, in_shape,
+ out_val, out_shape)
+
+ print('extract_image_patches gradient err: %.4e' % err)
I see the same print used earlier here
<https://github.com/tensorflow/tensorflow/blob/e67dc75850fe3a54071fdd9db6ad91906ad51797/tensorflow/python/kernel_tests/extract_image_patches_grad_test.py#L104>,
should I remove that as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29815?email_source=notifications&email_token=AAABHRMW2JA4MT2QNLMWME3P3E6SRA5CNFSM4HYOFJOKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB35P2ZA#discussion_r295003548>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABHRLV2XFCB5JDAHP7DSTP3E6SRANCNFSM4HYOFJOA>
.
--
- Alex
|
alextp
approved these changes
Jun 19, 2019
alextp
previously approved these changes
Jun 19, 2019
|
@alextp I fixed the pylint issue. Now it should be ok to merge automatically once you approve it again. |
alextp
approved these changes
Jun 20, 2019
tensorflow-copybara
pushed a commit
that referenced
this pull request
Jun 20, 2019
…_grad_fix PiperOrigin-RevId: 254241100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11651.
The unit test is taken from #17420.