Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install 'future' when building Docker images #30011

Merged
merged 1 commit into from Jun 20, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Expand Up @@ -168,8 +168,8 @@ There are two ways to run TensorFlow unit tests.
[GPU developer Dockerfile](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/dockerfiles/dockerfiles/devel-gpu.Dockerfile)
for the required packages. Alternatively, use the said
[Docker images](https://hub.docker.com/r/tensorflow/tensorflow/tags/), e.g.,
`tensorflow/tensorflow:nightly-devel` and
`tensorflow/tensorflow:nightly-devel-gpu` for development to avoid
`tensorflow/tensorflow:devel` and
`tensorflow/tensorflow:devel-gpu` for development to avoid
installing the packages directly on your system (in which case remember to
change directory from `/root` to `/tensorflow` once you get into the running
container so `bazel` can find the `tensorflow` workspace).
Expand Down
7 changes: 4 additions & 3 deletions tensorflow/tools/dockerfiles/assembler.py
Expand Up @@ -32,13 +32,13 @@
import copy
import errno
import itertools
import json
import multiprocessing
import os
import platform
import re
import shutil
import sys
import json

from absl import app
from absl import flags
Expand Down Expand Up @@ -162,6 +162,7 @@
# Note: can add python references with e.g.
# !!python/name:builtins.str
# !!python/name:__main__.funcname
# (but this may not be considered safe?)
SCHEMA_TEXT = """
header:
type: string
Expand Down Expand Up @@ -475,13 +476,13 @@ def main(argv):

# Read the full spec file, used for everything
with open(FLAGS.spec_file, 'r') as spec_file:
tag_spec = yaml.load(spec_file)
tag_spec = yaml.safe_load(spec_file)

# Get existing partial contents
partials = gather_existing_partials(FLAGS.partial_dir)

# Abort if spec.yaml is invalid
schema = yaml.load(SCHEMA_TEXT)
schema = yaml.safe_load(SCHEMA_TEXT)
v = TfDockerTagValidator(schema, partials=partials)
if not v.validate(tag_spec):
eprint('> Error: {} is an invalid spec! The errors are:'.format(
Expand Down
Expand Up @@ -92,6 +92,7 @@ RUN ${PIP} --no-cache-dir install \
scipy \
sklearn \
pandas \
future \
portpicker \
&& test "${USE_PYTHON_3_NOT_2}" -eq 1 && true || ${PIP} --no-cache-dir install \
enum34
Expand Down
Expand Up @@ -92,6 +92,7 @@ RUN ${PIP} --no-cache-dir install \
scipy \
sklearn \
pandas \
future \
portpicker \
&& test "${USE_PYTHON_3_NOT_2}" -eq 1 && true || ${PIP} --no-cache-dir install \
enum34
Expand Down
Expand Up @@ -124,6 +124,7 @@ RUN ${PIP} --no-cache-dir install \
scipy \
sklearn \
pandas \
future \
portpicker \
&& test "${USE_PYTHON_3_NOT_2}" -eq 1 && true || ${PIP} --no-cache-dir install \
enum34
Expand Down
Expand Up @@ -124,6 +124,7 @@ RUN ${PIP} --no-cache-dir install \
scipy \
sklearn \
pandas \
future \
portpicker \
&& test "${USE_PYTHON_3_NOT_2}" -eq 1 && true || ${PIP} --no-cache-dir install \
enum34
Expand Down
Expand Up @@ -19,6 +19,7 @@ RUN ${PIP} --no-cache-dir install \
scipy \
sklearn \
pandas \
future \
portpicker \
&& test "${USE_PYTHON_3_NOT_2}" -eq 1 && true || ${PIP} --no-cache-dir install \
enum34
Expand Down