Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL in docstring #30193

Merged

Conversation

duncanriach
Copy link
Contributor

The URL was out-of-date.

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Jun 27, 2019
@gbaned gbaned self-assigned this Jun 27, 2019
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jun 27, 2019
@gbaned gbaned requested a review from MarkDaoust June 27, 2019 04:56
@gbaned
Copy link
Contributor

gbaned commented Jul 8, 2019

@duncanriach Can you please resolve conflicts? Thanks!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 9, 2019
@duncanriach
Copy link
Contributor Author

What happened:

The original pull request was to fix the URL in a doc string. Then there was a conflict because someone else removed the URL. I rebased to master to resolve the conflict and I accidentally pushed a commit that had a ton of other people's changes in it. This is why so many reviewers were flagged. I rolled back that last commit and force-pushed.

This is a tiny change. Sorry for the confusion.

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 10, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 10, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 10, 2019
@tensorflow-copybara tensorflow-copybara merged commit 62ce1e9 into tensorflow:master Jul 10, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Jul 10, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jul 10, 2019
@duncanriach duncanriach deleted the test_docstring_fix branch October 17, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants