Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XLA] Add disable option to 2 XLA CC tests #30217

Merged
merged 3 commits into from
Jul 1, 2019
Merged

[XLA] Add disable option to 2 XLA CC tests #30217

merged 3 commits into from
Jul 1, 2019

Conversation

DavidNorman
Copy link
Contributor

Allow backends to disable tests from these 2 test suites using the manifest mechanism.

@tensorflow-bot tensorflow-bot bot added the size:M CL Change Size: Medium label Jun 28, 2019
@gbaned gbaned self-assigned this Jun 28, 2019
@gbaned gbaned added the comp:xla XLA label Jun 28, 2019
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jun 28, 2019
@gbaned gbaned requested a review from jlebar June 28, 2019 10:14
jlebar
jlebar approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@jlebar jlebar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbaned please check go/tf-who-do-i-notify for the person you should be assigning these PRs to. And please let us know if you can help us set up an "XLA group" in github, that would be even better.

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 28, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jun 28, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 28, 2019
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jul 1, 2019
@gbaned
Copy link
Contributor

gbaned commented Jul 1, 2019

@gbaned please check go/tf-who-do-i-notify for the person you should be assigning these PRs to. And please let us know if you can help us set up an "XLA group" in github, that would be even better.

@jlebar Thank you for the update. Sure, we will assign XLA PRs/bugs to new point of contact as per go/tf-who-do-i-notify

@yifeif yifeif merged commit 87d5f28 into tensorflow:master Jul 1, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Jul 1, 2019
yifeif pushed a commit that referenced this pull request Jul 1, 2019
@tensorflower-gardener
Merge pull request #30217 from DavidNorman:disable-tests
92ffb9e 
PiperOrigin-RevId: 255950843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebar jlebar jlebar approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:xla XLA ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@DavidNorman @gbaned @jlebar @yifeif @googlebot @kokoro-team