Fix numpy warning with numpy 1.17.0+ #30559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix tries to address the issue raised in 30427 where
`import tensorflow` caused the following warning with numpy 1.17.0+:
```
/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/framework/dtypes.py:516: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
```
The issue was cause by changes in numpy: numpy/numpy@ad1e060
This fix fixes the warning.
This fix fixes 30427.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This was referenced Jul 10, 2019
mihaimaruseac
approved these changes
Jul 10, 2019
tensorflow-bot
bot
added
kokoro:force-run
pull bot
pushed a commit
to Rachelmorrell/tensorflow
that referenced
this pull request
Jul 10, 2019
PiperOrigin-RevId: 257483885
|
what is the solution. Can u explain pls |
|
what is the solution then? I couldn't understand the procedure. What I understood is that to change the tensorflow version instead of numpy ? But how? |
|
Actually I downloaded numpy then It worked probably |
wchargin
pushed a commit
to tensorflow/tensorboard
that referenced
this pull request
Jul 31, 2019
This commit integrates upstream changes into TensorBoard’s `tensorflow_stub` to resolve a deprecation warning in recent release candidates for NumPy. Upstream bug: <tensorflow/tensorflow#30427> Upstream fix: <tensorflow/tensorflow#30559>
|
when does this land in a release? the warnings are a bit distracting atm. |
|
Cherry-picking this in #31333 for 1.14.1 patch release. It will also be included in a future main release shortly. |
|
@mihaimaruseac Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix tries to address the issue raised in #30427 where
import tensorflowcaused the following warning with numpy 1.17.0+:The issue was cause by changes in numpy: numpy/numpy@ad1e060
This fix fixes the warning.
This fix fixes #30427.
Signed-off-by: Yong Tang yong.tang.github@outlook.com