[ROCm] move nccl stream to member of StreamGroup #31483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the compute and nccl stream to be force-initialized as immediate siblings which is necessary for ROCm performance.
jeffdaily
changed the title
chsigg
previously approved these changes
Aug 12, 2019
tensorflow-bot
bot
added
kokoro:force-run
rthadur
added
ready to pull
|
@jeffdaily can you please resolve conflicts ? |
|
Can one of the admins verify this patch? |
chsigg
previously approved these changes
Aug 26, 2019
tensorflow-bot
bot
added
kokoro:force-run
|
@jeffdaily can you please resolve conflicts and we can run the tests once you are done, thank you |
rthadur
removed
kokoro:force-run
This also disables the multi-node emulation of the nccl_manager_test for the ROCm platform.
chsigg
approved these changes
Sep 5, 2019
tensorflow-bot
bot
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Sep 5, 2019
…ccl_stream_early PiperOrigin-RevId: 267404335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the compute and nccl stream to be force-initialized as immediate
siblings which is necessary for ROCm performance.