Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTEL MKL] In BUILD file fixed missing copts #32346

Closed
wants to merge 1 commit into from
Closed

[INTEL MKL] In BUILD file fixed missing copts #32346

wants to merge 1 commit into from

Conversation

shubham769
Copy link
Contributor

  • The -DINTEL_MKL compiler option was not getting passed to mkl related eager files
  • removed in a prior commit.
  • Added tf_copts to the build, tf_copts includes -DINTEL_MKL.

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Sep 9, 2019
@gbaned gbaned self-assigned this Sep 9, 2019
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Sep 9, 2019
@alextp alextp requested review from gunan and penpornk and removed request for alextp and jaingaurav September 9, 2019 14:45
@gunan
Copy link
Contributor

gunan commented Sep 9, 2019

Bazel is deprecating "nocopts" this was removed by bazel team because of that.
So adding it back wont help, and will break with bazel 1.0

@agramesh1
Copy link
Contributor

agramesh1 commented Sep 9, 2019 •
edited

Hi @gunan @penpornk This is duplicate of the PR #32317 submitted by Intel. This one is not from us. Please close this one.

@gunan gunan closed this Sep 9, 2019
PR Queue automation moved this from Assigned Reviewer to Closed/Rejected Sep 9, 2019
@mihaimaruseac mihaimaruseac added cla: no and removed cla: yes size:XS CL Change Size: Extra Small labels Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunan gunan Awaiting requested review from gunan

@penpornk penpornk Awaiting requested review from penpornk

Assignees
No one assigned
Labels
cla: no
Projects
PR Queue
  
Closed/Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shubham769 @gunan @agramesh1 @mihaimaruseac @googlebot @gbaned