[Intel MKL]code cleanup #33703
Merged
[Intel MKL]code cleanup #33703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisakshya
approved these changes
Oct 25, 2019
tensorflow-bot
bot
added
kokoro:force-run
|
@gbaned @adisakshya This PR has pending on ready to pull for 5 days, can you help to check this? thanks. |
gbaned
added
awaiting review
ezhulenev
approved these changes
Nov 6, 2019
| @@ -637,6 +638,7 @@ bool FindContractionWithBiasAndAddActivation( | |||
|
|
|||
| // Root of the pattern must be an activation node. | |||
| const auto* node_def = node_view->node(); | |||
| if (node_def == nullptr) return false; | |||
There was a problem hiding this comment.
Did this happen in practice? It's probably a bug somewhere if node def in null.
There was a problem hiding this comment.
@ezhulenev No, this just pass some tools check.
tensorflow-bot
bot
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Nov 6, 2019
PiperOrigin-RevId: 278923777 Change-Id: I9b8db719e535efe25ed2ff67495a19704c699b23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.