Fix the issue #32041: Fix riscv32_mcu link failure in build period. #33972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the ld error: undefined references to __wrap_puts for build commands like `make -f tensorflow/lite/experimental/micro/tools/make/Makefile TARGET=riscv32_mcu hello_world_bin` The related issue is #32041 The Makefile variables XXX_TEST_SRCS/XXX_SRCS in targets/mcu_riscv_makefile.inc are overridden by the the examples's respective makefile.inc (eg. hello_world/Makefile.inc), which leads to the architecture specified __wrap__funs are not included correctly.
For arduino sketch in of riscv_mcu examples, this patch fix this bug by declare the following global variable `void* __dso_handle;`.
zhoupeng
changed the title
zhoupeng
changed the title
zhoupeng
changed the title
… for update changes later. This reverts commit 6325b29.
…rences" for update change later. This reverts commit 2a18731.
Fix the ld error: undefined references to __wrap_puts for build commands like `make -f tensorflow/lite/experimental/micro/tools/make/Makefile TARGET=riscv32_mcu hello_world_bin` The related issue is #32041 The Makefile variables XXX_TEST_SRCS/XXX_SRCS in targets/mcu_riscv_makefile.inc are overridden by the the examples's respective makefile.inc (eg. hello_world/Makefile.inc), which leads to the architecture special __wrap__funs are not included correctly.
For arduino sketch in of riscv_mcu examples, this patch fix this bug by declare the global variable `void* __dso_handle;`.
For the `.bss' will not fit in region ram error, how to set freedom-e300-hifive1/flash.lds link scrip to get build pass.
This reverts commit fb3eb8f.
|
@nkreeger |
|
@zhoupeng Can you please resolve conflicts? Thanks! |
gbaned
added
stat:awaiting response
tensorflowbutler
added
the
stale
|
It has been 15 days with no activity and the |
NobuoTsukamoto
added a commit
to NobuoTsukamoto/tensorflow
that referenced
this pull request
Jan 3, 2020
|
@zhoupeng gentle ping to resolve conflicts. Thanks! |
|
It has been 29 days that this pull-request has stalled. Please create a new pull-request with the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #32041
Fix the ld error: undefined references to __wrap_puts for build commands like
make -f tensorflow/lite/experimental/micro/tools/make/Makefile TARGET=riscv32_mcu hello_world_binThe Makefile variables XXX_TEST_SRCS/XXX_SRCS in targets/mcu_riscv_makefile.inc are overridden by the the examples's respective makefile.inc (eg. hello_world/Makefile.inc), which leads to the architecture specified __wrap__funs are not included correctly.
__dso_handle' isn't defined. For arduino sketch in of riscv_mcu examples, this patch fix this bug by declare the following global variablevoid* __dso_handle;`make -f tensorflow/lite/experimental/micro/tools/make/Makefile TARGET=riscv32_mcu hello_world_test_binmake -f tensorflow/lite/experimental/micro/tools/make/Makefile TARGET=riscv32_mcu hello_world_bin