Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for minimum/maximum quantization quantization #34484

Merged
merged 9 commits into from Dec 16, 2019

Commits on Nov 21, 2019

  1. Fix for minimum/maximum quantization problem

    Problem description:
    MINIMUM and MAXIMUM operations were not quantized properly. Specifically, the problem was that only one of the inputs was quantized while another one was left in the original data type. Because of this reason, TFLite interpreter was failing to prepare since quantization params of ops did not match.
    
    Problem cause:
    MINIMUM and MAXIMUM operators were created in the way that they only had one input, not two. Hence when looping through inputs while quantizing them, only one of two inputs was quantized.
    
    Problem fix:
    Change the definition of the aforementioned properties.
    
    This patch contains fixes for the problem described above.
    
        Properties of MINIMUM and MAXIMUM operators were altered to have
        two inputs rather than one. This is safe since both 1.* and 2.* branches
        have only two inputs for these ops
        Test suite for testing Minimum and Maximum ops quantization is added
        Two small binaries have been added for testing purposes
    
    Change-Id: Ibcbfbf7bb7118a9f2cdd8ddc03e990015ba539d7
    wwwind committed Nov 21, 2019
    Copy the full SHA
    2c5dbcd View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Fix for the bug with maximum/minimum operator.

    In case of multiple inputs, we need to requantize all inputs to have the same scale
    and zero point.
    
    Change-Id: Ie1373f385c166eeca1521457195c5356c41c3d11
    wwwind committed Nov 22, 2019
    Copy the full SHA
    c966b0f View commit details
    Browse the repository at this point in the history
  2. Fix for the bug with maximum/minimum operator.

    In case of multiple inputs, we need to requantize all inputs to have the same scale
    and zero point.
    
    Change-Id: I903b278db8338b5b1da3d267ff6c258db09bcfef
    wwwind committed Nov 22, 2019
    Copy the full SHA
    6e50126 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Merge branch 'upstream/master' into fix_minimum_maximum

    Change-Id: Iaaf36acdc6df7194336d76d26ded8a2f03ce56d9
    wwwind committed Nov 27, 2019
    Copy the full SHA
    e71a586 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'fix_minimum_maximum' of github.com:wwwind/tensorflow in…

    …to fix_minimum_maximum
    
    Change-Id: I6039b4bcd283201cfb6a17b17fc5d4c4c7f7ccfe
    wwwind committed Nov 27, 2019
    Copy the full SHA
    6c3c149 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. Copy the full SHA
    811c2a0 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Copy the full SHA
    ec5d3a0 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Addressed review comments.

    Change-Id: I501414fdf7a769dbd027c6913029c14cc8ca1e06
    wwwind committed Dec 10, 2019
    Copy the full SHA
    78b7aa7 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Fixed sanity check.

    Change-Id: Ife08ec56980a71e778ea86cf34c5a9fc2153a3f0
    wwwind committed Dec 11, 2019
    Copy the full SHA
    fe404e6 View commit details
    Browse the repository at this point in the history