Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version 2.1 release note regarding TF_DETERMINISTIC_OPS #35006

Merged
merged 2 commits into from Dec 20, 2019

Conversation

duncanriach
Copy link
Contributor

This current pull request is intentionally aimed at the r2.1 branch.

This current pull request is a follow-up to PR 34887. Unfortunately, I didn't review the rendered markdown for those changes before submitting the PR.

This PR:

  • Changes the indent of the note about TF_DETERMINISTIC_OPS so that it doesn't appear to be related to TensorRT.
  • Escapes the use of * twice in the markdown, which was previously interpreted as intending to signal emphasis.
  • Adds some improvements to clarity.

Requesting review by @sanjoy, who reviewed the original PR.

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Dec 10, 2019
sanjoy
sanjoy previously approved these changes Dec 10, 2019
Copy link
Contributor

@sanjoy sanjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And sorry for not noticing earlier!

RELEASE.md Outdated Show resolved Hide resolved
@goldiegadde goldiegadde self-assigned this Dec 11, 2019
@goldiegadde goldiegadde requested review from goldiegadde and removed request for goldiegadde December 11, 2019 05:21
Copy link
Contributor

@sanjoy sanjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goldiegadde goldiegadde added the kokoro:force-run Tests on submitted change label Dec 11, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 11, 2019
@duncanriach
Copy link
Contributor Author

This PR has been ready to merge for 9 days. Please will someone merge it?

@mihaimaruseac
Copy link
Collaborator

Apologies, we didn't merge any PRs on the branch this week as we were debugging several segfaults caused by scipy/scipy#11237

We will start merging PRs in a while, when we finish this debugging process

@goldiegadde
Copy link
Contributor

@duncanriach sorry for the delay in merging the PR's. we have been debugging seg fault issues with scipy and hence the delay. Should be merged in soon.

@goldiegadde goldiegadde merged commit 36b67c1 into tensorflow:r2.1 Dec 20, 2019
@duncanriach
Copy link
Contributor Author

duncanriach commented Dec 20, 2019

@mihaimaruseac, thanks for the update.
@goldiegadde, thanks for the merge.

@duncanriach duncanriach deleted the fix-v2.1-release-note branch December 20, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:XS CL Change Size: Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants