Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TFLu: Add stm32f4 and build target #35854

Merged
merged 3 commits into from Feb 18, 2020
Merged

TFLu: Add stm32f4 and build target #35854

merged 3 commits into from Feb 18, 2020

Conversation

mansnils
Copy link
Contributor

Add new TARGET=stm32f4 that is working with Renode.
Add new target that will just build the test binaries.
Add new CI script for this as well.
The purpose of this is CMSIS-NN regression.

@mansnils
TFLu: Add stm32f4 and build target
8faed4f 
Add new TARGET=stm32f4 that is working with Renode.
Add new <build> target that will just build the test binaries.
Add new CI script for this as well.
The purpose of this is CMSIS-NN regression.
@tensorflow-bot tensorflow-bot bot added the size:L CL Change Size: Large label Jan 14, 2020
@gbaned gbaned self-assigned this Jan 14, 2020
@gbaned gbaned added comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers labels Jan 14, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 14, 2020
@gbaned gbaned added the awaiting review Pull request awaiting review label Jan 17, 2020
@mansnils
Copy link
Contributor Author

Gentle ping for review.

PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Jan 21, 2020
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Jan 22, 2020
@mansnils
TFLu: Update stm32f4 target
eefeac0 
Add stm32f4 specific renode script files, instead of reusing the
bluepill files.
petewarden
petewarden previously approved these changes Jan 25, 2020
View reviewed changes
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jan 25, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 25, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 25, 2020
@mansnils
Copy link
Contributor Author

Ready for merge

1 similar comment
@mansnils
Copy link
Contributor Author

mansnils commented Feb 4, 2020

Ready for merge

rthadur
rthadur suggested changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@rthadur rthadur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pasted internal error , please check ?

tensorflow/lite/micro/testing/test_stm32f4_binary.sh Show resolved Hide resolved
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Feb 7, 2020
@mansnils
TFLu: Update stm32f4 target
fde6c13 
Filter out failed test and increase RAM size.
@tensorflow-bot tensorflow-bot bot removed the ready to pull PR ready for merge process label Feb 10, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 11, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Feb 12, 2020
@mansnils
Copy link
Contributor Author

Do you know why these tests fail? They didn't fail on the first and second commit, so I wonder why they fail now.

tensorflow-copybara pushed a commit that referenced this pull request Feb 18, 2020
@tensorflower-gardener
Merge pull request #35854 from mansnils:renode
e087187 
PiperOrigin-RevId: 295777715
Change-Id: I5561aee7f8367d45cf55a717213da38a94867d3d
@tensorflow-copybara tensorflow-copybara merged commit fde6c13 into tensorflow:master Feb 18, 2020
PR Queue automation moved this from Reviewer Requested Changes to Merged Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rthadur rthadur rthadur requested changes

@petewarden petewarden petewarden approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers ready to pull PR ready for merge process size:L CL Change Size: Large
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mansnils @petewarden @rthadur @googlebot @kokoro-team @tensorflowbutler @tensorflow-copybara @gbaned