Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xla_lhlo.neg and xla_lhlo.abs support integer arguments #37381

Merged
merged 2 commits into from Apr 13, 2020
Merged

xla_lhlo.neg and xla_lhlo.abs support integer arguments #37381

merged 2 commits into from Apr 13, 2020

Conversation

qqsun8819
Copy link
Contributor

@qqsun8819 qqsun8819 commented Mar 6, 2020 •
edited

Do self transformation based on current mlir standard dialect

@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Mar 6, 2020
@qqsun8819
Copy link
Contributor Author

@joker-eph plz take a look ^_^

@gbaned gbaned self-assigned this Mar 6, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 6, 2020
@gbaned gbaned requested a review from jpienaar March 6, 2020 08:22
@qqsun8819 qqsun8819 changed the title xla_hlo.neg and xla_hlo.abs support integer arguments xla_lhlo.neg and xla_lhlo.abs support integer arguments Mar 6, 2020
@gbaned
Copy link
Contributor

gbaned commented Mar 11, 2020

@qqsun8819 Can you please check joker-eph's comments and resolve conflicts? Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Mar 11, 2020
@tensorflowbutler tensorflowbutler added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Mar 27, 2020
@tensorflowbutler
Copy link
Member

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

@qqsun8819
Copy link
Contributor Author

I'll update this PR according to what @joker-eph comment

@tensorflowbutler tensorflowbutler added stat:awaiting response Status - Awaiting response from author stale This label marks the issue/pr stale - to be closed automatically if no activity and removed stat:awaiting response Status - Awaiting response from author stale This label marks the issue/pr stale - to be closed automatically if no activity labels Apr 10, 2020
@qqsun8819
Copy link
Contributor Author

@joker-eph please take a look again ^_^

@qqsun8819
Copy link
Contributor Author

@joker-eph pr updated according to you comments, take a look again ^_^

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 11, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 11, 2020
@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Apr 13, 2020
@tensorflow-copybara tensorflow-copybara merged commit 3de660e into tensorflow:master Apr 13, 2020
@qqsun8819 qqsun8819 deleted the negabsi branch April 14, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker-eph joker-eph joker-eph approved these changes

@jpienaar jpienaar Awaiting requested review from jpienaar

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Approved by Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@qqsun8819 @gbaned @tensorflowbutler @joker-eph @googlebot @kokoro-team @tensorflow-copybara