Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not densify sparse gradients in LossScaleOptimizer #37566

Merged
merged 1 commit into from Mar 13, 2020
Merged

Do not densify sparse gradients in LossScaleOptimizer #37566

merged 1 commit into from Mar 13, 2020

Conversation

guillaumekln
Copy link
Contributor

The method get_unscaled_gradients is currently converting sparse gradients to dense gradients. We can avoid this implicit conversion to save on memory.

@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Mar 13, 2020
@gbaned gbaned self-assigned this Mar 13, 2020
@gbaned gbaned added the comp:keras Keras related issues label Mar 13, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 13, 2020
@gbaned gbaned requested a review from pavithrasv March 13, 2020 11:07
@pavithrasv pavithrasv requested review from reedwm and removed request for pavithrasv March 13, 2020 17:22
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 13, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 13, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 13, 2020
@reedwm
Copy link
Member

reedwm commented Mar 13, 2020

Thanks for the PR!

@tensorflow-copybara tensorflow-copybara merged commit d1dd08d into tensorflow:master Mar 13, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Mar 13, 2020
@guillaumekln guillaumekln deleted the do-not-densify-scaled-sparse-gradients branch March 16, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reedwm reedwm reedwm approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@guillaumekln @reedwm @googlebot @kokoro-team @tensorflow-copybara @gbaned