Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 36146 #38283

Merged
merged 6 commits into from
Apr 10, 2020
Merged

Fix issue 36146 #38283

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ec1788b
Improved error message to clarify why a custom mapping is not being a…
tonytonev Apr 6, 2020
a3e5597
Improved error message to clarify why a custom mapping is not being a…
tonytonev Apr 6, 2020
5ae891c
Merge branch 'master' of https://github.com/tensorflow/tensorflow
tonytonev Apr 6, 2020
f5670e4
Merge branch 'master' of https://github.com/tonytonev/tensorflow into…
tonytonev Apr 6, 2020
1c56ff4
Updated error message to add more information.
tonytonev Apr 7, 2020
72c5f28
Changed string format style to be compatible with python 2
tonytonev Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions tensorflow/python/util/nest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,15 @@ def _sequence_like(instance, args):
instance_type = type(instance)
tf_logging.log_first_n(
tf_logging.WARN, "Mapping types may not work well with tf.nest. Prefer"
"using MutableMapping for {}".format(instance_type), 1)
return instance_type((key, result[key]) for key in instance)
" using MutableMapping for {}".format(instance_type), 1)
try:
return instance_type((key, result[key]) for key in instance)
except TypeError as err:
raise TypeError("Error creating an object of type {} like {}. Note that "
"it must accept a single positional argument "
"representing an iterable of key-value pairs, in "
"addition to self. Cause: {}".format(type(instance),
instance, err))
elif _is_mapping_view(instance):
# We can't directly construct mapping views, so we create a list instead
return list(args)
Expand Down