Fix only pass RunOptions to keras will trigger core #38562
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR from JIZHI, the AI platform in Tencent.
Right now, keras will trigger segmentation fault when only pass
RunOptions
but noRunMetadata
. This bug can be replicated in tf-nightly in this gistIf you cannot open the gist, the code to replicate the bug is
The reason for this problem is that keras use the
TF_SessionRunCallable
api instead ofTF_Run
. While the former was using anunique_ptr
to represent therun_metadata
and will only new one whenRunMetadata
was passed. However, theRunOption
will need anRunMetadata
for tracing. This PR modified the implementation ofTF_SessionRunCallable
to that ofTF_Run
and fix this bug.Thank you for your time on reviewing this PR.