Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[grappler] Convert identity ConjugateTranspose to Conj instead of removing it #40223

Merged
merged 1 commit into from Jul 6, 2020
Merged

[grappler] Convert identity ConjugateTranspose to Conj instead of removing it #40223

merged 1 commit into from Jul 6, 2020

Conversation

zhuzilin
Copy link
Contributor

@zhuzilin zhuzilin commented Jun 6, 2020

This pr fixes the bug in #27500 where the identity conjugate transpose op was wrongly removed.

Thank you for your time on reviewing this pr.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jun 6, 2020
@gbaned gbaned self-assigned this Jun 8, 2020
@gbaned gbaned added the comp:grappler Grappler related issues label Jun 8, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jun 8, 2020
@gbaned gbaned requested a review from rmlarsen June 8, 2020 04:24
@gbaned gbaned added the awaiting review Pull request awaiting review label Jun 12, 2020
@zhuzilin
Copy link
Contributor Author

@gbaned
This pr has been waiting for reviewing for a while... Maybe we can add someone else to review it? I believe it is a pretty simple change and won't take too much time...

@gbaned gbaned requested a review from ezhulenev June 19, 2020 08:55
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jun 24, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 24, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 24, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Jun 24, 2020
@zhuzilin
Copy link
Contributor Author

zhuzilin commented Jul 3, 2020

@ezhulenev @gbaned
Could you help to merge this pr? Thank you! :).

@tensorflow-copybara tensorflow-copybara merged commit 3d99fc6 into tensorflow:master Jul 6, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Jul 6, 2020
@mohantym mohantym mentioned this pull request Apr 11, 2022
Closed
@rmlarsen
Copy link
Member

@zhuzilin thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezhulenev ezhulenev ezhulenev approved these changes

@rmlarsen rmlarsen Awaiting requested review from rmlarsen

Assignees

@gbaned gbaned

Labels
cla: yes comp:grappler Grappler related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zhuzilin @rmlarsen @ezhulenev @googlebot @kokoro-team @tensorflow-copybara @gbaned