-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type annotations to improve the tracing process of tf.function #40901
Merged
tensorflow-copybara
merged 17 commits into
tensorflow:master
from
rahul-kamat:tf-function-tracing-with-annotations
Jul 22, 2020
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5d08cdb
Create boolean flag to enable using type annotations to improve tracing
rahul-kamat 030fae9
Create TensorLike to be a Union of function input types
rahul-kamat b26422c
Add method to convert arguments annotated with TensorLike to tensors
rahul-kamat 34955fa
Add tests to verify tracing with annotations
rahul-kamat 35bd17b
Remove TensorLike and changes to types/core.py
rahul-kamat ae28e95
Change annotation check from TensorLike to Tensor
rahul-kamat 8d0a27b
Update boolean flag name and docstrings
rahul-kamat b1f5d9e
Add tests to validate only parameters typed with ops.Tensor are conve…
rahul-kamat 3bacebd
Update docstring description, Link docs for getfullargspec
rahul-kamat 18b3aa5
Update the goldens for api_test
rahul-kamat 0e79a26
fix pylint errors
rahul-kamat 265535e
Split kwargs annotation check into args and kwonlyargs
rahul-kamat dec9749
Update annotation check to handle kwonlyargs and kwargs, Add tests
rahul-kamat bf66190
delete newline
rahul-kamat a0c1834
Add 2 spaces before inline comments
rahul-kamat 5f59b9b
add pylint override comments
rahul-kamat bed05f4
Add a code example for tf.function, Update RELEASE.md
rahul-kamat File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional, if you get the chance: it would be ideal to disentangle these blocks, and separate them into stages:
That way the logic is easier to follow an verify, and you avoid the duplication of the "if annotation == ops.Tensor: convert" logic, which is expected to become more complex in time.