[INTEL MKL] MKL DNN v0.x cleanup - Reset MKL build config and remove DNN v0.x related macros #42339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penpornk
previously approved these changes
Aug 28, 2020
google-ml-butler
bot
added
kokoro:force-run
|
Thank you! |
|
Sounds good to me. Thank you for the heads up! :) |
|
@gzmkl Can you please address Ubuntu Sanity errors? Thanks! |
|
@gbaned. Hi, we just found that we (Intel) do not support "ngraph" bridge (third_party/ngraph) any more. We will soon support a new PR to clean away ngraph related configuration settings in Tensorflow. Once that PR is merged. This one will pass sanity check. THANKS! -GZ |
|
@gbaned I pushed a commit to fix ngraph build issue for this PR. We will continue to submit a new PR to remove ngraph bridge. But this PR will not pend on it. Thanks! |
google-ml-butler
bot
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Sep 11, 2020
PR #42339: [INTEL MKL] MKL DNN v0.x cleanup - Reset MKL build config and remove DNN v0.x related macros Imported from GitHub PR #42339 This is the first PR for MKL DNN v0.x clean - for Tensorflow 2.4, only MKL DNN v1.x will be supported (1) Reset MKL DNN related build config (mostly in third_part/mkl or mkl_dnn folder) (2) Remove MKL DNN v0.x related macros in core/util/mkl_types.c (3) Minor code style fix in one MKL kernel op. There will be a sequence of PR's which will clean up all related MKL kernels ops. PiperOrigin-RevId: 331205640 Change-Id: I2c3c3671fe8906a5dd18c6b017d05fc69a1e3f59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR for MKL DNN v0.x clean - for Tensorflow 2.4, only MKL DNN v1.x will be supported
(1) Reset MKL DNN related build config (mostly in third_part/mkl or mkl_dnn folder)
(2) Remove MKL DNN v0.x related macros in core/util/mkl_types.c
(3) Minor code style fix in one MKL kernel op.
There will be a sequence of PR's which will clean up all related MKL kernels ops.