[keras/optimizer_v2/ftrl.py] Reflect defaults in docstring #44679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
approved these changes
Nov 12, 2020
google-ml-butler
bot
added
kokoro:force-run
|
@SamuelMarks can you please check ubuntu sanity build failures ? |
|
@rthadur Fixed. |
rthadur
approved these changes
Nov 12, 2020
google-ml-butler
bot
added
kokoro:force-run
rthadur
added
ready to pull
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing an open-source typed wrapped for TensorFlow [and other ML frameworks], to enable good errors; parameter optimisation and analysis; over other interfaces like CLI, GUIs and decoupled frontends, databases, RPC, and REST.
The docstrings must reflect the defaults in the
__init__function, otherwise I'll need to extend my side to parse & merge the defaults—e.g., frominspect.Signatureor fromast—with theclass's docstring.So this'll probably be the first of many trivial change PRs I'll be sending over 👍