Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TFTRT] Add Dynamic Shape Testing for ConvertConv3D #46940

Merged
merged 1 commit into from
Feb 24, 2021
Merged

[TFTRT] Add Dynamic Shape Testing for ConvertConv3D #46940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3318,6 +3318,14 @@ Status ConvertConv3DHelper(OpConverterParams* params, int group,
}
}

// Channel dim must be static for Conv3D since we use that value for
// num_groups at build time.
// TODO: Allow conversion if kImplicitBatchModeCompatible||kOptimal is used.
if (tensor->getDimensions().d[c_index] == -1) {
return errors::InvalidArgument("Channel dimension must be static, at ",
node_def.name());
}

// Finished validation checks
if (params->validation_only) return Status::OK();

Expand Down